Hi,
do you plan to release the actual master as Anvil 0.5.0 or are you planning major changes?

Btw, great work 👍

@gmarques33 Anvil 0.5.0 is planned to be released this week, and good news is that the public API is backwards-compatible with Anvil 0.4.0. Although, internally lots of things have changed, and new added APIs such as custom attribute factories or view factories or Anvil.skip() might not be final yet.

@zserge Cool. I look forward to trying the new changes. We are testing it in a project and I believe that 0.5.0 changes will help a lot.
If we keep using it, we can contribute with feedback and pull requests 👍

I'm trying to use the bottomNavigationView introduced in this merge, but simply cannot get it to trigger my NavigationItemSelectedListener. Is this functionality not complete? The documentation on such components is currently non-existent. @zserge

class HomeView(c: Context) : RenderableView(c) {

    private val mOnNavigationItemSelectedListener = BottomNavigationView.OnNavigationItemSelectedListener { item ->
        when (item.itemId) {
            R.id.navigation_home -> {
                println("HOME")
                return@OnNavigationItemSelectedListener true
            }
            R.id.navigation_dashboard -> {
                println("Dash")
                return@OnNavigationItemSelectedListener true
            }
            R.id.navigation_notifications -> {
                println("Notif")
                return@OnNavigationItemSelectedListener true
            }
        }
        false
    }

    override fun view() {
        frameLayout {
            size(BaseDSL.MATCH, BaseDSL.MATCH)

            bottomNavigationView {
                gravity(BaseDSL.BOTTOM)
                size(BaseDSL.MATCH, BaseDSL.WRAP)
                onNavigationItemSelected(mOnNavigationItemSelectedListener)

                bottomNavigationMenuView {
                    bottomNavigationItemView {
                        title("Home")
                        id(R.id.navigation_home)
                        icon(ContextCompat.getDrawable(context, R.drawable.ic_home_black_24dp))
                    }
                    bottomNavigationItemView {
                        title("Dash")
                        id(R.id.navigation_dashboard)
                        icon(ContextCompat.getDrawable(context, R.drawable.ic_home_black_24dp))
                    }
                    bottomNavigationItemView {
                        title("Notif")
                        id(R.id.navigation_notifications)
                        icon(ContextCompat.getDrawable(context, R.drawable.ic_home_black_24dp))
                    }
                }
            }
        }
    }
}

@jakst Yes, it's another gift from Android Support Library developers, similar to #81 and friends.

Basically, they are violating the common convention of the view constructors. BottomNavigationView is a view group, but it injects child views automatically, as well as having other side effects such as binding together the menu presented and menu view. In other words, you can't create a BottomNavigationView in pure java without using XMLs.

Here's where the child view is added: https://android.googlesource.com/platform/frameworks/support/+/master/design/src/android/support/design/widget/BottomNavigationView.java#171

But this particular case is not so bar. One can specify the Menu resource in code, so I've been using the following view method in my component and it worked well:

        public void view() {
            frameLayout(() -> {
                size(MATCH, MATCH);

                bottomNavigationView(() ->  {
                    init(() -> {
                        ((BottomNavigationView) Anvil.currentView()).inflateMenu(R.menu.bottom_nav_example);
                    });

                    gravity(BOTTOM);
                    size(MATCH, WRAP);
                    onNavigationItemSelected(mOnNavigationItemSelectedListener);
                });
            });
        }

Here I'm creating a view in java, but my menu items are declared in menu XML, much like the documentation suggests. Not as good as pure Kotlin (or Java), but it seems to be the only possible way. An alternative would be to re-write BottomNavigationView as your own class that would be Java- (and thus, Anvil-) friendly.

@jakst You might want to open a separate issue if you would prefer to have a separate method like menu(int resource) instead of the init(...) + inflateMenu trick. A solution would be to modify quirks file and re-generate the DSL code, so you might want to offer a pull request to make it faster.

UPD: Sorry, it looks like inflateMenu is not a reusable setter method and should only be called once. I this case perhaps the init() approach is cleaner, because it explicitly shows that the method is called once.