Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong return code for resolution change #106

Open
any1 opened this issue Nov 8, 2023 · 0 comments
Open

Wrong return code for resolution change #106

any1 opened this issue Nov 8, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@any1
Copy link
Owner

any1 commented Nov 8, 2023

When a client request a resolution change, returning true from the callback results in RFB_RESIZE_STATUS_SUCCESS being sent over the wire.

It would be more accurate to return RFB_RESIZE_STATUS_REQUEST_FORWARDED because the resolution isn't actually changed until the frame buffer dimensions change and when that happens, the server sends a resize event to the client.

This does not seem to cause any issues, but it is a spec violation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant