Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow automatic schema inference when registering csv #313

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Allow automatic schema inference when registering csv #313

merged 1 commit into from
Oct 3, 2022

Conversation

r4ntix
Copy link
Contributor

@r4ntix r4ntix commented Oct 3, 2022

Which issue does this PR close?

Closes #287

Rationale for this change

See #287

What changes are included in this PR?

When the schema field is empty, use automatic inference schema mode

Are there any user-facing changes?

None

@r4ntix r4ntix mentioned this pull request Oct 3, 2022
Closed
avantgardnerio
avantgardnerio approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@avantgardnerio avantgardnerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I would have spent a while trying to track this down 🙌 🥳

andygrove
andygrove approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @r4ntix

@andygrove andygrove merged commit c882c1f into apache:master Oct 3, 2022
@r4ntix r4ntix deleted the issues-287 branch March 18, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

@avantgardnerio avantgardnerio avantgardnerio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema inference does not work in Ballista-cli with a remote context
3 participants
@r4ntix @andygrove @avantgardnerio