Avoid calling scheduler when the executor cannot accept new tasks #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
Oct 17, 2022
|
|
||
| // Don't poll for work if we can not accept any tasks | ||
| if !can_accept_task { | ||
| tokio::time::sleep(Duration::from_millis(1)).await; |
There was a problem hiding this comment.
Is there any reasoning behind picking 1 ms versus any other value? Would it be less overhead to sleep for longer here, maybe 10 ms? Should we make this configurable?
There was a problem hiding this comment.
I think checking the value is really cheap (e.g. compared to grpc requests), so I did use the minimum to reduce the latency as much as possible when a job is running.
I wonder if we can use some lock or channel instead of this loop in the future to rewrite this without sleep 🤔 and use resources more efficiently...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #377
Rationale for this change
Improves performance, especially when using a more limited number of task slots by avoiding a longer sleep between runs.
Running with 1 executor and task slots=1:
Timings(ms):
What changes are included in this PR?
Are there any user-facing changes?