Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade DataFusion to 21.0.0 #727

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Upgrade DataFusion to 21.0.0 #727

merged 2 commits into from
Apr 3, 2023

Conversation

r4ntix
Copy link
Contributor

@r4ntix r4ntix commented Mar 28, 2023

Which issue does this PR close?

Upgrade DataFusion to 21.0.0

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@yahoNanJing
Copy link
Contributor

yahoNanJing commented Apr 3, 2023 •
edited
Loading

Thanks @r4ntix. How about extracting the feature based store into a single method, like the following does
https://github.com/yahoNanJing/arrow-ballista/blob/84a98d73a164b655b80f4391611de4c499b27f73/ballista/core/src/utils.rs#L105-L179? Then we can separate the get and register logic.

@r4ntix
Copy link
Contributor Author

r4ntix commented Apr 3, 2023

Thanks @r4ntix. How about extracting the feature based store into a single method, like the following does https://github.com/yahoNanJing/arrow-ballista/blob/84a98d73a164b655b80f4391611de4c499b27f73/ballista/core/src/utils.rs#L105-L179? Then we can separate the get and register logic.

@yahoNanJing thanks for the feedback. i will submit a new commit for it a little later.

yahoNanJing
yahoNanJing approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@yahoNanJing yahoNanJing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yahoNanJing yahoNanJing merged commit 32f9793 into apache:main Apr 3, 2023
@r4ntix r4ntix deleted the upgrade-datafusion branch April 11, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dandandan Dandandan Dandandan approved these changes

@yahoNanJing yahoNanJing yahoNanJing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r4ntix @yahoNanJing @Dandandan