Fix plan metrics length and stage metrics length not match #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @andygrove, could you help have a check? |
|
I also found this issue today and am locating it, glad to see that there is already a PR fix for this issue 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #763.
We got lots of error log as follows due to mismatch of the length between plan metrics and stage metrics:
2023-04-27T07:08:05.745787Z ERROR tokio-runtime-worker ThreadId(07) ballista_scheduler::display: Fail to combine stage metrics to plan for stage [5H4NLbc/3], plan metrics array size 5 does not equal to the stage metrics array size 4The metrics length of stage is always one less than the one of plan.
Rationale for this change
It's caused by #687.
What changes are included in this PR?
Are there any user-facing changes?