Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as_any() to the ObjectStore to make it able to identify which ObjectStore is using for the related trait object #3838

Closed
yahoNanJing opened this issue Mar 10, 2023 · 1 comment
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog

Comments

@yahoNanJing
Copy link

yahoNanJing commented Mar 10, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The context is we are working on introducing a data source cache layer for Ballista & DataFusion apache/datafusion-ballista#645. The cache layer will be able to multiple ObjectStore data. And we need to leverage the identification of the ObjectStore.

Describe the solution you'd like

Add as_any() to the ObjectStore to make it able to identify which ObjectStore is using for the related trait object.

Describe alternatives you've considered

Additional context

@tustvold
Copy link
Contributor

tustvold commented Mar 10, 2023

And we need to leverage the identification of the ObjectStore.

Could you expand a bit on what you mean by this, why does the cache need to know the backing implementation? Surely this is an encapsulated detail?

@tustvold tustvold closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2023
@tustvold tustvold added the development-process Related to development process of arrow-rs label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
2 participants