Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpannerIO tests don't actually assert anything. #20529

Closed
damccorm opened this issue Jun 4, 2022 · 1 comment · Fixed by #23365
Closed

SpannerIO tests don't actually assert anything. #20529

damccorm opened this issue Jun 4, 2022 · 1 comment · Fixed by #23365
Labels
gcp io P2 python tests

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 4, 2022

These all have the format


p = Pipeline()
...
p.run()
assert_that(...)

Imported from Jira BEAM-10569. Original Jira may contain additional context.
Reported by: robertwb.
@Abacn
Copy link
Contributor

Abacn commented Jun 8, 2022

There is a cross-language spanner io (apache_beam.io.gcp.spanner) and this native implementation is less actively supported and may be deprecated in the future. May decrease the priority of this issue.

@Abacn Abacn mentioned this issue Jun 22, 2022
Closed
@damccorm damccorm added P2 and removed P1 labels Jun 23, 2022
@Abacn Abacn mentioned this issue Sep 25, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gcp io P2 python tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support google-cloud-spanner v3 and fixes broken unit tests Abacn/beam
2 participants
@Abacn @damccorm