instanceId.get() being called when using Dataflow Templates after upgrading to 2.40.0

[jeffreyung]

beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java

Line 165 in b53b16f

Preconditions.checkNotNull(instanceId.get());

beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java

Line 177 in b53b16f

Preconditions.checkNotNull(databaseId.get());

I've built a Dataflow pipeline template which uses the SpannerConfig class and, after upgrading to BEAM 2.40.0, it fails to build because instanceId.get() is being called and it seems that this line is causing the issue.

I suspect this may break the existing Google-provided Dataflow Templates which uses Spanner.

[bvolpato]

Also reported here https://stackoverflow.com/questions/73765145/apache-beam-illegalstateexception-value-only-available-at-runtime-after-upgra

Will give it a shot .take-issue

[bvolpato]

.remove-labels stale
.add-labels gcp, io, java

[github-actions]

Label cannot be managed because it does not exist in the repo. Please check your spelling.

[bvolpato]

.add-labels bug,gcp,io,java,P1