Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TImeout StreamingDataflowWorkerTest when test stuck #29065

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 18, 2023

mitigate #28957

A testing PR #23785 found a stuck test path

Class org.apache.beam.runners.dataflow.worker.StreamingDataflowWorkerTest

testActiveThreadMetric[0: [streamingEngine=false]]
org.junit.runners.model.TestTimedOutException: test timed out after 600 seconds
	at java.lang.Object.wait(Native Method)
	at java.lang.Object.wait(Object.java:502)
	at org.apache.beam.runners.dataflow.worker.StreamingDataflowWorkerTest.testActiveThreadMetric(StreamingDataflowWorkerTest.java:2850)
...

this would make the test under this test class timeout after 600s, instead the whole test suite hanging indefinitely

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Oct 18, 2023

R: @ahmedabu98
CC: @kerrydc

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor Author

Abacn commented Oct 18, 2023

e.g. this happened again in jenkins: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/28702/

@Abacn
Copy link
Contributor Author

Abacn commented Oct 18, 2023

Run Java PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Oct 19, 2023

R: @edman124 @bvolpato

this test was recently added in #28513 . Besides adding a timeout, any chance to know why it could stuck indefinitely?

@Abacn Abacn mentioned this pull request Oct 19, 2023
3 tasks
@edman124
Copy link
Contributor

The notify could be called before we enter the synchronized block causing wait to wait indefinitely, this test should be fixed in #29041
LGTM as a temporary stopgap

@Abacn Abacn merged commit 7632d48 into apache:master Oct 19, 2023
19 checks passed
@Abacn Abacn deleted the timeouttest branch October 19, 2023 22:43
kkdoon pushed a commit to twitter-forks/beam that referenced this pull request Oct 21, 2023
@Abacn Abacn mentioned this pull request Oct 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants