Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prometheus metrics configurable #514

Open
thinkharderdev opened this issue Nov 11, 2022 · 0 comments
Open

Make prometheus metrics configurable #514

thinkharderdev opened this issue Nov 11, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@thinkharderdev
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

In #511 we've added prometheus metrics in the default build of the ballista scheduler but the metrics exposed (and more importantly the histogram buckets used) are currently hard-coded.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Allow users to configure metrics. This should be along two dimensions:

  1. We may support an increasing set of metrics which we can track, but users may only want to track a subset of them. In that case they should be able to toggle on/off metrics.
  2. For histogram metrics, they should be able to configure the histogram buckets.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Users can always implement a custom SchedulerMetricsCollector and do whatever they want, but it is pain since they will not be able to use the standard image and will have to build their project themselves and manage their own entrypoint.

Alternatively, we could somehow leverage a plugin mechanism for this

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant