Fix regression in DataFrame.write_xxx #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
andygrove
changed the title
andygrove
commented
Dec 30, 2023
| @@ -145,7 +145,7 @@ where | |||
| fn listen_on_get_if_present(&self, k: Self::K, v: Option<Self::V>) { | |||
| if self.listeners.len() == 1 { | |||
| self.listeners | |||
| .get(0) | |||
| .first() | |||
Dandandan
approved these changes
Dec 30, 2023
andygrove
commented
Dec 30, 2023
Comment on lines
+465
to
+466
| #[cfg(feature = "standalone")] | ||
| mod standalone_tests { |
There was a problem hiding this comment.
Drive-by cleanup to declare that the whole module requires the standalone feature rather than declare this on each import and each test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #894
Status
Rationale for this change
Fix a major regression where we can no longer save the results of a query.
What changes are included in this PR?
Are there any user-facing changes?