Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add support for M1 macOS runner #9117

Closed
Weijun-H opened this issue Feb 3, 2024 · 5 comments · Fixed by #9191
Closed

CI: add support for M1 macOS runner #9117

Weijun-H opened this issue Feb 3, 2024 · 5 comments · Fixed by #9191
Labels
development-process Related to development process of DataFusion enhancement New feature or request good first issue Good for newcomers

Comments

@Weijun-H
Copy link
Member

Weijun-H commented Feb 3, 2024

Is your feature request related to a problem or challenge?

Github Action supports M1 macOS runner, and it will be better to integrate it in the current ci.
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@Weijun-H Weijun-H added the enhancement New feature or request label Feb 3, 2024
@Jefffrey Jefffrey added the development-process Related to development process of DataFusion label Feb 3, 2024
@alamb
Copy link
Contributor

alamb commented Feb 8, 2024

Yes, this would be very nice (and give us coverage of the aarch64 architecture which we don't have yet)

@alamb
Copy link
Contributor

alamb commented Feb 8, 2024

I think this would be a matter of changing https://github.com/apache/arrow-datafusion/blob/10e6d1870280296b31c6faff29ddf3f8fe98bbc4/.github/workflows/rust.yml#L295-L309

However, that already says "macos latest" so maybe we are already running in M1 macs 🤔

@alamb
Copy link
Contributor

alamb commented Feb 8, 2024

The new runner operates exclusively on macOS 14 and to use it, simply update the runs-on key in your YAML workflow file to macos-14.

I double checked and the latest CI seems to run on macos-12
https://github.com/apache/arrow-datafusion/actions/runs/7818251058/job/21328033495

Current runner version: '2.312.0'
Operating System
  macOS
  1[2](https://github.com/apache/arrow-datafusion/actions/runs/7818251058/job/21328033495#step:1:2).7.[3](https://github.com/apache/arrow-datafusion/actions/runs/7818251058/job/21328033495#step:1:3)
  21H1015
Runner Image
  Image: macos-12
  Version: 202[4](https://github.com/apache/arrow-datafusion/actions/runs/7818251058/job/21328033495#step:1:4)0202.1
  Included Software: https://github.com/actions/runner-images/blob/macOS-12/20240202.1/images/macos/macos-12-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macOS-12%2F20240202.1

@alamb alamb added the good first issue Good for newcomers label Feb 8, 2024
@alamb
Copy link
Contributor

alamb commented Feb 8, 2024

I think this would be a pretty good issue for someone new to the project

@alamb
Copy link
Contributor

alamb commented Feb 8, 2024

I would recommend updating the workflow file and then making a test PR in your fork to trigger the CI to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants