Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move make_array array_append array_prepend array_concat function to datafusion-functions-array crate #9322

Closed
guojidan opened this issue Feb 23, 2024 · 5 comments · Fixed by #9504
Closed

move make_array array_append array_prepend array_concat function to datafusion-functions-array crate #9322

guojidan opened this issue Feb 23, 2024 · 5 comments · Fixed by #9504
Assignees
@guojidan
Labels
enhancement New feature or request

Comments

@guojidan
Copy link
Contributor

guojidan commented Feb 23, 2024 •
edited
Loading

Is your feature request related to a problem or challenge?

sub-issue of #9285

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context
@guojidan guojidan added the enhancement New feature or request label Feb 23, 2024
@guojidan
Copy link
Contributor Author

take

@guojidan guojidan changed the title move ArrayAppend, ArraySort, ArrayConcat, ArrayHas, ArrayHasAll, ArrayHasAny to datafusion-functions-array crate move Array related function to datafusion-functions-array crate Feb 23, 2024
@jayzhan211
Copy link
Contributor

I plan to work on make_array. Not sure which one are you working on, but I think it is better to move the functions one by one unless they are similar.

@guojidan
Copy link
Contributor Author

I already do make_array array_append array_prepend array_concat, because this function is related in optimizer

@Lordworms
Copy link
Contributor

Lordworms commented Feb 25, 2024 •
edited
Loading

You can leave Range since I would do to cover issue #9323 , I would wait for you to complete the scratch and then port it.(Thanks)

@guojidan guojidan changed the title move Array related function to datafusion-functions-array crate move make_array array_append array_prepend array_concat function to datafusion-functions-array crate Feb 26, 2024
@guojidan
Copy link
Contributor Author

I changed this issue title, as @jayzhan211 said, it is better to move the functions one by one unless they are similar.

@guojidan guojidan mentioned this issue Feb 26, 2024
Closed
@guojidan guojidan mentioned this issue Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guojidan guojidan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@jayzhan211 @Lordworms @guojidan