[Improvement-16137][UI] Sub process support other project child node #16138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #16138 +/- ##
=========================================
Coverage 41.07% 41.07%
Complexity 5155 5155
=========================================
Files 1399 1399
Lines 44856 44856
Branches 4756 4756
=========================================
Hits 18423 18423
Misses 24628 24628
Partials 1805 1805 ☔ View full report in Codecov by Sentry. |
|
@songjianet PTAL |
ruanwenjun
reviewed
Jun 17, 2024
Comment on lines
391
to
393
| child_node_project: 'Child Node Project', | ||
| child_node_project_tips: | ||
| 'Select this field for choose different project child node', |
There was a problem hiding this comment.
I would prefer to use Project rather than Child Node Project
|
caishunfeng
reviewed
Jun 27, 2024
Comment on lines
+67
to
+70
| queryProjectListPaging({ | ||
| pageNo: 1, | ||
| pageSize: 999 | ||
| }) |
There was a problem hiding this comment.
I think it's better to add api to query all projects for user.
| params: { | ||
| id: res.subProcessInstanceId, | ||
| projectCode: | ||
| props.data.taskParams?.childNodeProjectCode || |
There was a problem hiding this comment.
Suggested change
| props.data.taskParams?.childNodeProjectCode || | |
| props.data.taskParams?.subProjectCode || |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #16162
Brief change log
Verify this pull request