Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-51][Task] Remove unused pigeon task plugin #16219

Merged
merged 9 commits into from
Jun 28, 2024

Conversation

SbloodyS
Copy link
Member

Purpose of the pull request

close #16218

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 26, 2024
@SbloodyS SbloodyS self-assigned this Jun 26, 2024
@github-actions github-actions bot added UI ui and front end related backend test document labels Jun 26, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jun 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.19%. Comparing base (0e2d0fb) to head (d954f72).

Current head d954f72 differs from pull request most recent head 9836227

Please upload reports for the commit 9836227 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16219      +/-   ##
============================================
- Coverage     41.24%   41.19%   -0.05%     
+ Complexity     5121     5099      -22     
============================================
  Files          1397     1391       -6     
  Lines         44055    43838     -217     
  Branches       4666     4652      -14     
============================================
- Hits          18171    18060     -111     
+ Misses        24104    24007      -97     
+ Partials       1780     1771       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

caishunfeng
caishunfeng previously approved these changes Jun 27, 2024
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

EricGao888
EricGao888 previously approved these changes Jun 27, 2024
@SbloodyS SbloodyS dismissed stale reviews from EricGao888 and caishunfeng via 8fb382f June 27, 2024 14:32
@github-actions github-actions bot added the e2e e2e test label Jun 27, 2024
Copy link

sonarcloud bot commented Jun 27, 2024

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 225e969 into apache:dev Jun 28, 2024
63 of 64 checks passed
@SbloodyS SbloodyS deleted the dsip_51 branch June 28, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend document e2e e2e test improvement make more easy to user or prompt friendly test UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSIP-51][Task] Remove unused pigeon task plugin
5 participants