Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure thread safety of ConstantExprs #16021

Closed
gianm opened this issue Mar 1, 2024 · 1 comment
Closed

Ensure thread safety of ConstantExprs #16021

gianm opened this issue Mar 1, 2024 · 1 comment
Labels
Bug
Milestone
30.0.0

Comments

@gianm
Copy link
Contributor

gianm commented Mar 1, 2024

To my eyes, PR #15552 introduced some code that is questionable as to thread safety of ConstantExprs: #15552 (comment). This was reverted for the 29 release branch, but is still present in master. To avoid any questionableness, we should address it somehow prior to releasing Druid 30. Some options:
@gianm gianm added the Bug label Mar 1, 2024
@gianm gianm added this to the 30.0.0 milestone Mar 1, 2024
@kgyrtkirk
Copy link
Member

fixed in #15694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
30.0.0
Development

No branches or pull requests
2 participants
@gianm @kgyrtkirk