-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web Console] Datasource page support search datasource by keyword #16371
[Web Console] Datasource page support search datasource by keyword #16371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really cool, thank you for the change. Added some style comments, also you should run script/licenses
(from the web-console directory) to update the license list since you added a package. Do these changes + resolve conflicts and it is good to go IMO
web-console/src/components/segment-timeline/segment-timeline.tsx
Outdated
Show resolved
Hide resolved
@vogievetsky Thank you so much for helping on this, I have updated the code as recommended. |
…:fectrain/druid into router_page_support_search_by_datasource
Hi, @vogievetsky I just merged the latest master branch and now all CI checks has passed, hope it is ready for merging, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you for addressing the feedback!
…pache#16371) * Frontend segment_timeline support filter by datasource * add dependency * fix eslint issues * resolve code style issue, update snapshot * fix comment * update licence * update package-lock.json * update snapshot * Update segment-timeline.tsx * Update segment-timeline.tsx
Fixes #16370 .
Description
This PR has: