Usage of new Random(constant seed) in tests

[leventov]

On the one hand, it's good because it makes the tests 100% deterministic and test failures reproducible.

On the other hand, compared to ThreadLocalRandom.current() or new Random(seed) with a random seed, a constant seed may not allow to explore all input conditions and discover some failing corner cases.

So ideally the seed should be generated randomly and be a parameter of a test, recorded in the test name. So when a test fails, it could be run locally with the known seed parameter in order to reproduce a test failure.

[leventov]

Related to #6226

[stale]

This issue has been marked as stale due to 280 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

[github-actions]

This issue has been marked as stale due to 280 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If this issue is still
relevant, please simply write any comment. Even if closed, you can still revive the
issue at any time or discuss it on the dev@druid.apache.org list.
Thank you for your contributions.