Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Checkstyle check for String literal equality #8386

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Add Checkstyle check for String literal equality #8386

merged 1 commit into from
Aug 28, 2019

Conversation

SandishKumarHN
Copy link
Contributor

@SandishKumarHN SandishKumarHN commented Aug 23, 2019 •
edited
Loading

Fixes #8330 :
Adding Style check for == != on Strings

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

@SandishKumarHN
Copy link
Contributor Author

@leventov default stylecheck module "StringLiteralEquality" checks, if there is any usage of == or != on Strings.

@SandishKumarHN
Copy link
Contributor Author

@leventov can we merge this?

@leventov leventov changed the title 8330 : Adding style check for == != Add Checkstyle check for String literal equality Aug 28, 2019
@leventov leventov merged commit f4e2902 into apache:master Aug 28, 2019
@jon-wei jon-wei added this to the 0.17.0 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leventov leventov leventov approved these changes

Assignees
No one assigned
Labels
Area - Automation/Static Analysis
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

Catch wrong use of ==/!= and equals()/!equals() in equals() implementations
4 participants
@SandishKumarHN @leventov @clintropolis @jon-wei