Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit Futures.addCallback(Future, Callback) (i. e. using directExecutor() implicitly) using forbidden-apis #8756

Open
leventov opened this issue Oct 26, 2019 · 0 comments

Comments

@leventov
Copy link
Member

This method is deprecated and removed from later versions of Guava for good reasons. Using this method mindlessly causes problems like #8445.

While Druid is stuck with older Guava, it should prohibit the problematic method proactively using forbidden-apis, forcing specifying an executor explicitly, and actually thinking about which executor should be used.

There are currently 19 usages of this method in Druid production code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant