Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale comments in compaction logic #8839

Open
leventov opened this issue Nov 7, 2019 · 0 comments
Open

Stale comments in compaction logic #8839

leventov opened this issue Nov 7, 2019 · 0 comments
Assignees
@jihoonson
Labels
Bug

Comments

@leventov
Copy link
Member

leventov commented Nov 7, 2019

https://github.com/apache/incubator-druid/blob/517c14632eb627e355840c4991520606608d4caf/server/src/main/java/org/apache/druid/server/coordinator/helper/NewestSegmentFirstIterator.java#L315-L326

-- references intervalToSearch but there is no longer such parameter to the method.

https://github.com/apache/incubator-druid/blob/517c14632eb627e355840c4991520606608d4caf/server/src/test/java/org/apache/druid/server/coordinator/helper/NewestSegmentFirstPolicyTest.java#L115-L124

-- references SegmentCompactorUtil.LOOKUP_PERIOD but there is no longer such constant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jihoonson jihoonson

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leventov @jihoonson