Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LATEST(expr, maxBytes) doesn't work on columns ingested as stringLast. #9756

Open
Aka-shi opened this issue Apr 23, 2020 · 3 comments
Open

Comments

@Aka-shi
Copy link

Aka-shi commented Apr 23, 2020

Description

I have ingested few columns using stringLast aggregator, which stores the data as pair of time and value. I got to know that the idea is to use the same aggregator on both ingestion and query sides. But the LATEST(expr, maxBytes) doesn't work on columns stored as stringLast.

Affected Version

Version - 0.17.0

Slack thread

@Aka-shi
Copy link
Author

Aka-shi commented Apr 23, 2020

@gianm

@gianm
Copy link
Contributor

gianm commented Apr 30, 2020

Thanks for the report. I think what we'll need to do is update the signature of the EarliestLatestSqlAggFunction so it accepts either STRING or OTHER (which stringLast should show up as) for its string form, and then add a test to make sure it works.

@Aka-shi
Copy link
Author

Aka-shi commented May 16, 2020

@gianm Can you review the PR I raised to fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants