fix(custom): fix user-defined info property was not available in the event handler
#18400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovilia
requested changes
Mar 20, 2023
|
@Ovilia it seems that the test case is already there: https://github.com/sobolewsk/echarts/blob/branches/fix-issue-15789/test/custom-feature.html#L124 |
|
NVM, I figured it out. Unit test added. |
Ovilia
requested changes
Mar 21, 2023
test/ut/spec/series/custom.test.ts
Outdated
| @@ -69,4 +69,46 @@ describe('custom_series', function () { | |||
| expect(resultPaletteColors).toEqual(colors); | |||
| }); | |||
|
|
|||
| it('should pass user defined data to event handlers', async () => { | |||
| const data = [ | |||
| [10, 16,], | |||
There was a problem hiding this comment.
Thanks for reviewing. Fixed!
Ovilia
approved these changes
Mar 23, 2023
|
Thank you @Ovilia for reviewing and merging! |
plainheart
changed the title
info property was not available in the event handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes #15789
Fixed issues
Details
Before: What was the problem?
The
infofield (user defined data) was not available in the event handler.After: How does it behave after the fixing?
The
infofield is now properly passed to the event handlers. To verify please use thetest/custom-feature.htmltest.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information