Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Leverage Velox monolithic build for better caching to speed up CI #6577

Open
zhztheplayer opened this issue Jul 24, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@zhztheplayer
Copy link
Member

zhztheplayer commented Jul 24, 2024

Description

facebookincubator/velox#9948 was merged. We'd change to the new build method to make Velox build up a single libvelox.a which can be easily cached among different CI runs as long as Velox's code doesn't get changed.

A possible issue is libvelox.a probably collides with Velox backend's libvelox.so more or less so we may consider changing name for the latter.

In most cases that Velox's code doesn't change, we expect the enhancement could save up to 1 hour during running CI, for a PR that changes Gluten's C++ code so requires to build C++ library on GitHub runner.

@zhztheplayer zhztheplayer added the enhancement New feature or request label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant