Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass TransformationTracker instead of changeListener to the passes #57

Open
konnov opened this issue Sep 2, 2019 · 1 comment
Open
Assignees
Labels
Fparallel Feature: Integrating the parallel checker refactoring

Comments

@konnov
Copy link
Collaborator

konnov commented Sep 2, 2019

For instance, this is how PreproPassImpl looks like this:

class PreproPassImpl @Inject()( val options: PassOptions,
                                changeListener: ChangeListener,
                                @Named("AfterPrepro") nextPass: Pass with TlaModuleMixin)
[...]
 val tracker : TransformationTracker = TrackerWithListeners( changeListener )
[...]

Instead of passing ChangeListener, pass TransformationTracker. A concrete implementation of TransformationTracker should be defined by the module that instantiates the pass.

@konnov konnov added this to the BMCMT-0.6-release-refactoring milestone Sep 2, 2019
@konnov konnov modified the milestones: BMCMT-0.6-release-refactoring, BMCMT-0.7-dev-multicore Feb 4, 2020
@konnov
Copy link
Collaborator Author

konnov commented Feb 4, 2020

The ModelChecker API has changed quite a bit in ik/multicore, so let's postpone this issue for v0.7.0.

@konnov konnov added the Fparallel Feature: Integrating the parallel checker label Dec 11, 2020
@konnov konnov modified the milestones: v0.8.0-dev-multicore, backlog2021 Dec 11, 2020
@shonfeder shonfeder removed this from the backlog2021 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fparallel Feature: Integrating the parallel checker refactoring
Projects
None yet
Development

No branches or pull requests

3 participants