Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stomp.py optional #120

Open
tofu-rocketry opened this issue Feb 6, 2020 · 0 comments
Open

Make stomp.py optional #120

tofu-rocketry opened this issue Feb 6, 2020 · 0 comments
Labels
enhancement

Comments

@tofu-rocketry
Copy link
Member

tofu-rocketry commented Feb 6, 2020 •
edited
Loading

Making argo-ams-library optional was done in #119, but making stomp.py optional is a fiddly task as stomp.py has a lot of low level integration in the code, which will need careful unpicking.

It may work to have a base Ssm2 class and then a class for each of AMS and STOMP that inherit from it such that only the STOMP one is a stomp.ConnectionListener.

Once done, this will hopefully enable pulling out AMS and STOMP functions to their own files/classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tofu-rocketry