Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL error "Can not execute the operation on ended Span" #2652

Closed
velias opened this issue Jul 3, 2023 · 5 comments · Fixed by #2697
Closed

OTEL error "Can not execute the operation on ended Span" #2652

velias opened this issue Jul 3, 2023 · 5 comments · Fixed by #2697
Assignees

Comments

@velias
Copy link

velias commented Jul 3, 2023

Issue Description

If subgraph call fails with http error (eg. 400), then there is error Can not execute the operation on ended Span {traceId: 496674e5d6add505f18b5cdcb6259322, spanId: e9285ed17413b036} in the app log from otel module. SpanId in the message is from gateway.postprocessing span. Looks like some error/result reporting doesn't work correctly for this Span.

Link to Reproduction

https://github.com/velias/apollographql-federation-issue-2652-reproducer

Reproduction Steps

  • setup logging from otel
  • execute query on gateway which produces http error in subgraph
  • look into gateway log file
@trevor-scheer trevor-scheer self-assigned this Jul 7, 2023
@trevor-scheer
Copy link
Member

Hey @velias, this isn't a trivial reproduction. Please share a repository I can clone which demonstrates the issue without any creativity on my part with any necessary steps I need to take to trigger the error.

@velias
Copy link
Author

velias commented Jul 10, 2023

OK, but I'm leaving for holiday later this week, not sure if I'll be able to provide it before. So be patient please.

@velias
Copy link
Author

velias commented Jul 11, 2023

OK, was able to do it today, reproducer is here https://github.com/velias/apollographql-federation-issue-2652-reproducer
Instructions in README.md

@trevor-scheer
Copy link
Member

Thanks @velias! Hoping to get a look at this tomorrow.

@velias
Copy link
Author

velias commented Aug 2, 2023

Thanks for the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants