Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .p8 support for APNS? #247

Closed
reaperdtme opened this issue Jul 9, 2017 · 7 comments · Fixed by #300
Closed

Add .p8 support for APNS? #247

reaperdtme opened this issue Jul 9, 2017 · 7 comments · Fixed by #300
Assignees
Labels

Comments

@reaperdtme
Copy link

Apple has new .p8 certificate. One cert for all applications. Can we get support for this?

@appleboy
Copy link
Owner

@zaiddag Could you use token-based authentication as an alternative to using provider certificates to connect to APNs or something else?

How do you create certificate with extension .p8?

@appleboy appleboy self-assigned this Jul 10, 2017
@reaperdtme
Copy link
Author

@appleboy Yes. Yes you can. You can make them in Apple's developer console. It uses JWT.

Here's our fork of Apns2 that uses p8 for Apple auth.
https://github.com/unmute/apns2

It looks like Apns2 had the feature ~ 8 months ago but did not release it. It's sitting on the feature-auth-token branch here:
https://github.com/sideshow/apns2/tree/feature-auth-token

But, Apns2 is on a block actually:
sideshow/apns2#43

Waiting on support for MAX_CONNECTIONS

@reaperdtme
Copy link
Author

Looks like Go 1.9 will have the Http2 fix

@appleboy
Copy link
Owner

@zaiddag maybe we should wait @sideshow merge this sideshow/apns2#43 PR.

@sideshow
Copy link

sideshow commented Jul 11, 2017

@appleboy @zaiddag re: sideshow/apns2#43
Correct, its still blocked due to support for MAX_CONNECTIONS
I am considering merging this anyway and documenting as a known issue, because for most people this will still work well. Its only those who are flooding the connection when it opens that will have an issue

@appleboy
Copy link
Owner

I will implement this feature this week.

@appleboy
Copy link
Owner

@KidCosmic Implementation in #300

changes from config.yml

ios:
  enabled: false
  key_path: "key.pem"
  password: "" # certificate password, default as empty string.
  production: false
  max_retry: 0 # resend fail notification, default value zero is disabled
+ key_id: "" # KeyID from developer account (Certificates, Identifiers & Profiles -> Keys)
+ team_id: "" # TeamID from developer account (View Account -> Membership)

update key_path as your .p8 file and add Key ID and Team ID from Apple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants