Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider using krew-release-bot for publishing plugin releases #57

Closed
rajatjindal opened this issue Feb 2, 2020 · 6 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@rajatjindal
Copy link

What would you like to be added

I have created krew-release-bot to auto publish new plugin releases to krew-index repo.

Why is this needed

it automates the publishing step to krew-index repo and therefore reduce the manual step needed.

If its ok with who-can authors, I can open a PR to start using that for auto publishing the releases or you can look at the travis example here, and configure it.

Many thanks for considering.
Rajat Jindal

@rajatjindal rajatjindal added the enhancement New feature or request label Feb 2, 2020
@danielpacak
Copy link
Contributor

What would you like to be added

I have created krew-release-bot to auto publish new plugin releases to krew-index repo.

Why is this needed

it automates the publishing step to krew-index repo and therefore reduce the manual step needed.

If its ok with who-can authors, I can open a PR to start using that for auto publishing the releases or you can look at the travis example here, and configure it.

Many thanks for considering.
Rajat Jindal

Hi @rajatjindal and thank your for opening the issue. I love the idea and always opt in for any possible automation. I'm just wondering wether we should migrate from Travis to GitHub Actions first and then add your bot or give it a try with Travis. @lizrice WDYT?

@rajatjindal
Copy link
Author

rajatjindal commented Feb 3, 2020 via email

@danielpacak
Copy link
Contributor

Thanks for taking out time to reply, If its ok with you, i can open PR with migration to github actions + the bot I see that you are using goreleaser, so it should be relatively straight forward.

Sorry for not replying sooner to that @rajatjindal

Before we proceed I'd like to understand the runtime / sandbox environment of the bot. Does that mean that the bot has access to encrypted secrets configured for the GitHub project? If such access is not granted by default, does that mean that we could only pass secrets and other sensitive data as environment variables or command args?

@rajatjindal
Copy link
Author

Np.

The bot itself do not require any secrets and in github actions by default it does not have access to secrets (thats my understanding, pls correct me if thats not right)

All we need is access to releases (to calculate sha256) and krew template file.

Hope that helps

@danielpacak
Copy link
Contributor

danielpacak commented Mar 24, 2020

Np.

The bot itself do not require any secrets and in github actions by default it does not have access to secrets (thats my understanding, pls correct me if thats not right)

All we need is access to releases (to calculate sha256) and krew template file.

Hope that helps

I checked on my end and indeed the bot does not require access to project secrets: https://krew.sigs.k8s.io/docs/developer-guide/release/updating-plugins/

With that I'd love to automate it. What do you think about splitting the work into two tasks:

  • Migrate to GitHub Actions
  • Add krew-release-bot to the workflow config

/cc @lizrice

@krol3
Copy link
Contributor

krol3 commented Jun 26, 2020

I'd to help :), I will start to work it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants