Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOG]Add loggers for logical/physical sql and tx(#596) #694

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

Mulavar
Copy link
Contributor

@Mulavar Mulavar commented Jun 24, 2023

What this PR does:
Add loggers for logical/physical sql and tx.

Which issue(s) this PR fixes:

Fixes #596

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c696476) 36.42% compared to head (974de38) 36.42%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   36.42%   36.42%           
=======================================
  Files         228      228           
  Lines       23759    23759           
=======================================
+ Hits         8654     8655    +1     
+ Misses      14106    14105    -1     
  Partials      999      999           
Impacted Files Coverage Δ
pkg/config/misc.go 0.00% <0.00%> (ø)
pkg/executor/redirect.go 3.81% <0.00%> (ø)
pkg/runtime/namespace/command.go 16.27% <0.00%> (ø)
pkg/runtime/runtime.go 3.36% <0.00%> (ø)
pkg/runtime/tx.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
16.1% 16.1% Duplication

@dongzl dongzl added the enhancement New feature or request label Jun 24, 2023
@AlexStocks AlexStocks merged commit c95f464 into arana-db:master Jun 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] add log for sharding logic SQL and real SQL.
6 participants