Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for /arana/pkg/trace/... #767

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

RayMario
Copy link
Contributor

What this PR does:
add unit test for /arana/pkg/trace/...
github.com/arana-db/arana/pkg/trace coverage: 100.0% of statements
github.com/arana-db/arana/pkg/trace/jaeger coverage: 90.9% of statements

Which issue(s) this PR fixes:

Fixes #741

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RayMario RayMario changed the title Add ut 741 add unit test for /arana/pkg/trace/... Sep 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.24% 🎉

Comparison is base (b40e2af) 39.30% compared to head (7f79e16) 39.55%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   39.30%   39.55%   +0.24%     
==========================================
  Files         259      263       +4     
  Lines       26477    26595     +118     
==========================================
+ Hits        10407    10519     +112     
- Misses      14939    14943       +4     
- Partials     1131     1133       +2     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongzl dongzl added this to the 0.2.0 milestone Sep 18, 2023
@dongzl dongzl added the test Unit test. label Sep 18, 2023
@AlexStocks AlexStocks merged commit 29509ce into arana-db:master Sep 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Unit test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test] add unit test for /arana/pkg/trace/... package.
5 participants