Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send to closed chan in discovery #768

Merged

Conversation

jjeffcaii
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.9% 10.9% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

Patch coverage: 90.90% and project coverage change: +0.09% 🎉

Comparison is base (df70525) 39.45% compared to head (9a014e9) 39.55%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
+ Coverage   39.45%   39.55%   +0.09%     
==========================================
  Files         261      261              
  Lines       26542    26561      +19     
==========================================
+ Hits        10471    10505      +34     
+ Misses      14940    14926      -14     
+ Partials     1131     1130       -1     
Files Changed Coverage Δ
pkg/boot/discovery_watch.go 62.06% <90.90%> (+21.86%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongzl dongzl added this to the 0.2.0 milestone Sep 18, 2023
@dongzl dongzl added the bug Something isn't working label Sep 18, 2023
@dongzl dongzl merged commit 4657262 into arana-db:master Sep 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants