Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure privatelink integration is impossible #438

Open
omelchukvladyslav opened this issue Nov 30, 2022 · 1 comment
Open

Azure privatelink integration is impossible #438

omelchukvladyslav opened this issue Nov 30, 2022 · 1 comment

Comments

@omelchukvladyslav
Copy link

Describe the bug
We are not able to use Azure keyvault privatelink integration due to hardcoded values in Azure backend, so we are able only to provide the name of keyvault so the path is different than privatelink endpoint

To Reproduce
kvpath = fmt.Sprintf("https://%s.vault.azure.net", kvpath)

Expected behavior
Be able to use privatelink endpoint for keyvault - .privatelink.vaultcore.azure.net

Screenshots/Verbose output
image

@werne2j
Copy link
Member

werne2j commented Mar 22, 2023

So i guess we would just need to accept an environment variable and override if provided. Feel free to put up a PR and we can review if this is a feature you need. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants