-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitbucket server eventsource regressions #3175
Comments
Hrm that's probably a regression. I will take look next week when I'm back from vacation. |
Fixed in my latest change to #3135. We are turning off webhook management as we are using Bitbucket v8 now and it has the ability to manage repository webhooks at the project level, negating the need for this feature. When we turned it off we ran into the same problem. I am validating the fix over the next day. |
i still see stuff like "applyBitbucketServerWebhooks ensures all configured repositories have the correct webhook settings applied." can you make it have an option to not make any api calls to bitbucket? i want argo-events to listen to a port, then i manually configure bitbucket with my personal user (outside of argo) to point requests to the port |
It skips creating webhooks if the following conditions are not met.
Additionally checkout the below code. Where when setting up the event source it determines if bitbucket clients should be setup and webhooks. |
This issue has been automatically marked as stale because it has not had |
crunchy |
in v1.8.1 everything worked fine
but in v1.9.2 it fails for few reasons
accesstoken is mandatory now https://github.com/argoproj/argo-events/blob/v1.9.2/eventsources/sources/bitbucketserver/start.go#L225
list webhooks fails now (not all users have access for that)
https://github.com/argoproj/argo-events/blob/v1.9.2/eventsources/sources/bitbucketserver/start.go#L336
what i'm confused with is why this is now trying to list/create webhook directly on bitbucket when before the eventsource would purely setup an independent endpoint that could be curled. and u could manually create the bitbucket webhook in bitbucket ui itself to point to the endpoint.
cc @ryancurrah
The text was updated successfully, but these errors were encountered: