-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colab #50
Comments
I'm sorry I have never used Colab nor I know what it's used for, so I don't know. |
Unfortunately, I never used Nim.
But I don't know how to run
|
Just wondering, have you tested the reliability of qr codes with pictures? What parameters should be used to create a qr code so that it works 100% of the time with all phones?
|
The problem is not the phone but the QR scaner used, depending on the scanner it may or may not read complicated QR codes, like ones with rounded corners, spacing or even images. Also the image should not be a problem since it calculates it's max size depending on the selected ECC level, so the amount of broken bits can be recovered. |
For some reason
|
Yes, let qr = newQR("https://github.com/aruZeta/QRgen")
writeFile(
"build" / "testingSvg.svg",
qr.printSvg
) |
Yes, that's intended behaviour, to avoid it you would just add a non-transparent background to your image, but oh well there should be a way to force a square to be drawn behind it. |
Do you mean that all the svg need to be specially edited by placing them on an non-transparent background rectangle of the same color as the background of the qr code? Also, the size of this rectangle must be manually adjusted for each qr code so that its borders do not partially overlap the dots of the qr code itself and do not divide them into two parts, right? |
The current implementation does not offer a way to force a background for transparent images. |
As I said it's not that there is a reason of why you can't force a layer between the QR and the image, so as in a way to act as the background of the image, but that it's just not implemented. It shouldn't be a difficult task, but I will try it whenever I have the time and energy to do it. |
I see, thank you. Anyway, you did a very good job. And it would be absolutely perfect if you manage to add a way to force a background for transparent images. |
Yeah it's something that's missing from the library, but I'm very sorry I don't have any time atm. |
Can I run it in Colab?
The text was updated successfully, but these errors were encountered: