Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with markdown-it-attrs? #13

Closed
f0rr0 opened this issue Sep 21, 2016 · 4 comments
Closed

Compatibility with markdown-it-attrs? #13

f0rr0 opened this issue Sep 21, 2016 · 4 comments

Comments

@f0rr0
Copy link

f0rr0 commented Sep 21, 2016

This

![Stuff](./salty_egg.jpg) {.full-width}

produces

<p class="full-width">
  <img src="./salty_egg.jpg" alt="Stuff">
</p>

instead of:

<fig class="full-width">
  <img src="./salty_egg.jpg" alt="Stuff">
  <figcaption>Stuff</figcaption>
</fig>
@arve0
Copy link
Owner

arve0 commented Sep 22, 2016

Thanks for reporting. Fixed in markdown-it-attrs 0.7.1.

@arve0 arve0 closed this as completed Sep 22, 2016
@coryschires
Copy link

@arvo Thanks for all your hard work on this plugin!

Unfortunately, I'm still encountering the problem described above – even when using all the latest versions of markdown-it, markdown-it-implicit-figures, and markdown-it-attrs.

I've recreated this issue in this fiddle: https://jsfiddle.net/xsywjrzr/1/

Thanks again and let me know if there's anything I can do to help!

@arve0
Copy link
Owner

arve0 commented Apr 24, 2017

Hm, strange. I'm currently away from the computer, so unable to look into it. Feel free to poke around in the code.

I'll be back later this week.

@arve0
Copy link
Owner

arve0 commented May 19, 2017

See #18. Fixed in markdown-it-attrs 0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants