Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highly Opinionated Grafana Port Configurations and References #13

Open
SN3-K opened this issue Jul 11, 2023 · 0 comments · May be fixed by #17
Open

Highly Opinionated Grafana Port Configurations and References #13

SN3-K opened this issue Jul 11, 2023 · 0 comments · May be fixed by #17

Comments

@SN3-K
Copy link

SN3-K commented Jul 11, 2023

https://github.com/ascendcorp/grafana-snapshot/blob/2a2214662fb6f92702a60843358b462aafd5124e/GrafanaSnapshot/feature/snapshots.py#L54C76-L54C80

Through out most of this code there is the assumption the end user is utilizing port 3000 and not using custom port configurations, wherein you can configure the library to connect to the remote grafana, the urls generated to the end user will show up not as host+port but as localhost:3000 or host:3000.

Instead we should allow the user to configure global variables that dictate the host and port for the entire library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant