Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which command #178

Merged
merged 9 commits into from
Jul 4, 2017
Merged

Which command #178

merged 9 commits into from
Jul 4, 2017

Conversation

fcrespo82
Copy link
Contributor

Hi guys, this is my attempt to do the which command it fixes #72 and #150.

I guess it could be better when returning the main binary, but I think would need a Plugin API change.

Hope it helps!

@danhper
Copy link
Member

danhper commented May 15, 2017

Thank you very much, and sorry for the delay.
I will try the branch locally, and let you know if I run into any issue.
If you get a moment, could you rebase on top of master as it seems we introduced some changes to completions/asdf.bash at some point.
Again, thank you 😃

@fcrespo82
Copy link
Contributor Author

Hi @tuvistavie, just updated the branch with the changes to completions/asdf.bash.
It should be able to merge without conflicts now.
Thank you.

@Stratus3D Stratus3D merged commit 37bb033 into asdf-vm:master Jul 4, 2017
@Stratus3D
Copy link
Member

Thanks @fcrespo82 ! Sorry it took so long to merge this.

@Stratus3D
Copy link
Member

Stratus3D commented Jul 4, 2017

It would be nice if we could pass any arbitrary name to this command. For example:

$ asdf which ruby
/home/trevor/.asdf/installs/ruby/2.3.0/bin/ruby
$ asdf which irb
No such plugin

It would be better if the second command returned /home/trevor/.asdf/installs/ruby/2.3.0/bin/irb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Command to get direct path of the binary
3 participants