-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return error if library functions aren't found, instead of panicking #387
Comments
That's rather trivial to add - I guess you're just 4 minutes late to get the 0.32 release. Feel free to submit a PR :) |
Ah, well I can't complain about a new version when I asked for it before! :D I was initially thinking only about |
Agreed, the entry loaders are loading "optional" functionality (ie. can't load 1.2 functions from a 1.1 library). Not sure if all the Entry functions are "core" functions and should all be available if a certain Vulkan version is declared. Perhaps it is nice to see up-front that certain functions failed to load (while not preventing the rest from loading) but that is definitely not required, feature availability can be checked in other ways. |
EntryCustom::new_custom
doesn't return any error, it assumes the given library contains the functions it needs. If they aren't present, then the function panics. That's less than ideal if smoother error handling is needed, I would prefer it if the function returnedResult
if the library isn't a valid Vulkan library in some way. This would also propagate toEntry::new
. Could this be implemented?The text was updated successfully, but these errors were encountered: