Add data support for stubbed error responses. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks so much, @steam! The CI failure is not your fault – I'll get it fixed up ASAP. Could you write a quick test or two on your end for the new NSData associated value? |
|
I saw you got the CI failure fixed. Nice work! I've added a spec for the stubbed nsdata error. Should be good to go. Thanks! |
|
Nah, not fixed yet, but this looks awesome! 🍻 |
ashfurrow
added a commit
that referenced
this pull request
Jan 7, 2015
Add data support for stubbed error responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to stub data when testing errors. In production many of our errors have structured data. This allows unit tests to account for them. (Thanks for all the hard work on Moya, we are very happy with it so far.)