Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ruff to ruff check alias #10171

Open
MichaReiser opened this issue Feb 29, 2024 · 3 comments · May be fixed by #12833
Open

Remove the ruff to ruff check alias #10171

MichaReiser opened this issue Feb 29, 2024 · 3 comments · May be fixed by #12833
Labels
breaking Breaking API change
Milestone

Comments

@MichaReiser
Copy link
Member

MichaReiser commented Feb 29, 2024

We deprecated the ruff to ruff check, ruff --explain to ruff rule, ruff --generate-shell-completion to ruff generate-shell-completion and the ruff --clean to ruff clean aliases in 0.3. Ruff 0.5 changed the commands to error. We should remove the aliases in an upcoming minor release.

#10169
#12011

Note that the ruff-lsp used the ruff to ruff check alias astral-sh/ruff-lsp#392

@MichaReiser
Copy link
Member Author

#12011 made using any of the above commands a hard error, but we keep printing an error. We should remove the commands entirely in a future release (0.6? or 0.7?)

@charliermarsh
Copy link
Member

So the current state is that these have a custom error, and the task here is to remove the custom errors?

@MichaReiser
Copy link
Member Author

So the current state is that these have a custom error, and the task here is to remove the custom errors?

Exactly

@MichaReiser MichaReiser linked a pull request Aug 12, 2024 that will close this issue
@MichaReiser MichaReiser modified the milestones: v0.6, v0.7 Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking API change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants