Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule proposal: keyword argument before star arguments #1400

Closed
andersk opened this issue Dec 27, 2022 · 1 comment · Fixed by #1416
Closed

Rule proposal: keyword argument before star arguments #1400

andersk opened this issue Dec 27, 2022 · 1 comment · Fixed by #1416
Assignees
@charliermarsh
Labels
good first issue Good for newcomers rule Implementing or modifying a lint rule

Comments

@andersk
Copy link
Contributor

andersk commented Dec 27, 2022

Python disallows f(kw=a, b), f(**a, b), and f(**a, *b), but for some reason it does not disallow f(kw=a, *b), which has an unexpected evaluation order as of 3.5 (python/cpython#100549). We could add a warning for this.
@charliermarsh charliermarsh added rule Implementing or modifying a lint rule good first issue Good for newcomers labels Dec 27, 2022
@charliermarsh
Copy link
Member

Sounds reasonable!

@charliermarsh charliermarsh self-assigned this Dec 28, 2022
@charliermarsh charliermarsh mentioned this issue Dec 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
good first issue Good for newcomers rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rule to detect keyword arguments before starred arguments astral-sh/ruff
2 participants
@andersk @charliermarsh