Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I001 + UP026 fix collision leads to invalid trailing comma #1572

Closed
andersk opened this issue Jan 2, 2023 · 2 comments
Closed

I001 + UP026 fix collision leads to invalid trailing comma #1572

andersk opened this issue Jan 2, 2023 · 2 comments

Comments

@andersk
Copy link
Contributor

andersk commented Jan 2, 2023

You’ve probably noticed this from the failing CI, but here’s a minimal test case:

if True:
    from mock import mock, a, b, c

After ruff --select=I001,UP026:

if True:
    from unittest.mock import a, b, c,

which has an invalid trailing comma.
@andersk
Copy link
Contributor Author

andersk commented Jan 2, 2023

Oh yes, you have (#1570).

@andersk andersk closed this as completed Jan 2, 2023
@charliermarsh
Copy link
Member

😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andersk @charliermarsh