Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noqa: E402 not detected #2198

Closed
spaceone opened this issue Jan 26, 2023 · 3 comments · Fixed by #2783
Closed

noqa: E402 not detected #2198

spaceone opened this issue Jan 26, 2023 · 3 comments · Fixed by #2783
Labels
bug Something isn't working

Comments

@spaceone
Copy link
Contributor

print(1)
from very_long_module\
    import nothing  # noqa: E402,F401

doesn't detect E402

@spaceone
Copy link
Contributor Author

spaceone commented Jan 26, 2023

similar (but I think another issue exists for it already):
F811 is not ignored.

def overload(f): pass
from typing import (  # noqa: F401,F811
    overload,
)

@charliermarsh charliermarsh added the bug Something isn't working label Jan 26, 2023
@spaceone
Copy link
Contributor Author

See also #2253

@Pierre-Sassoulas
Copy link
Contributor

Similar issue:

This noqa is valid in flake8 but not detected by ruff:

        is_to_run = (
            lambda x: 1  # type: ignore[assignment,misc] # pylint: disable=unnecessary-lambda-assignment
        )  # noqa: E731 We're going to throw all this anyway

(While this one work for both:)

        is_to_run = (  # noqa: E731, We're going to throw all this anyway
            lambda x: 1  # type: ignore[assignment,misc] # pylint: disable=unnecessary-lambda-assignment
        )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants