Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid-module-name (N999) should not apply to non-*.py files #3151

Closed
andersk opened this issue Feb 23, 2023 · 1 comment · Fixed by #3153
Closed

invalid-module-name (N999) should not apply to non-*.py files #3151

andersk opened this issue Feb 23, 2023 · 1 comment · Fixed by #3153
Assignees
Labels
bug Something isn't working

Comments

@andersk
Copy link
Contributor

andersk commented Feb 23, 2023

A script that isn’t named *.py (example) must be intended to be invoked from the command line, not imported as a module. So it doesn’t matter if its name is an invalid module name, and we should not emit

scripts/restart-server:1:1: N999 Invalid module name: 'restart-server'

Cc @sbrugman (#2855)

By the way, although we document this rule as being from pep8-naming, it isn’t; it’s from flake8-module-name.

@charliermarsh
Copy link
Member

Thanks. I can fix this real quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants