Collapse short multi-line import groups to one line with I001

[andersk]

Ruff, like upstream isort, expands single-line import groups that are too long to multiple lines.

-from typing import Any, Callable, Dict, List, Mapping, Optional, Sequence, Tuple, TypeVar
+from typing import (
+    Any,
+    Callable,
+    Dict,
+    List,
+    Mapping,
+    Optional,
+    Sequence,
+    Tuple,
+    TypeVar,
+)

Upstream isort, but not Ruff, also does the reverse: it collapses multi-line import groups that are short enough to a single line. I think we should do this too.

-from typing import (
-    Any,
-    Callable,
-    Dict,
-    List,
-    Mapping,
-    Optional,
-    Sequence,
-    Tuple,
-)
+from typing import Any, Callable, Dict, List, Mapping, Optional, Sequence, Tuple

[charliermarsh]

I believe we collapse such imports if you disable split-on-trailing-comma.

I've looked into this before, and isort's documentation states that this setting is enabled for profile = "black", but in practice it appears not to be.

[andersk]

It works for me (isort 5.12.0).

$ cat > a.py
from typing import (
    Any,
    Callable,
)
$ isort --profile=black a.py
Fixing /tmp/a.py
$ cat a.py
from typing import Any, Callable

[charliermarsh]

What I meant is that: the isort documentation suggests that it shouldn't be removing magic trailing commas there. The documentation says that split-on-trailing-comma: true is the default for that profile. But in practice it appears not to be.

[charliermarsh]

To be clear: we support this behavior, it's just not our default.

[andersk]

Got it. Feel free to close if you think this should remain as is.

I guess this is a duplicate of

• Change isort.split-on-trailing-comma default to false #4153

[charliermarsh]

I'm torn on it but I'm going to leave as-is for now.