Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should respect isort:skip comments #674

Closed
andersk opened this issue Nov 11, 2022 · 3 comments · Fixed by #678
Closed

Should respect isort:skip comments #674

andersk opened this issue Nov 11, 2022 · 3 comments · Fixed by #678
Assignees
@charliermarsh
Labels
isort Related to import sorting

Comments

@andersk
Copy link
Contributor

andersk commented Nov 11, 2022

ruff currently respects noqa: I001 comments to prevent sorting certain imports. For improved isort compatibility, it should also respect isort:skip and isort:skip_file comments (documentation).
@andersk andersk mentioned this issue Nov 11, 2022
Closed
@charliermarsh
Copy link
Member

Good call.

@charliermarsh
Copy link
Member

It looks like isort:off and isort:on are recommended in the docs, so maybe I'll do those first.

@charliermarsh charliermarsh added the isort Related to import sorting label Nov 11, 2022
@charliermarsh
Copy link
Member

Some extremely crude metrics from code search:

Screen Shot 2022-11-10 at 10 34 02 PM

Screen Shot 2022-11-10 at 10 34 10 PM

Screen Shot 2022-11-10 at 10 34 17 PM

@charliermarsh charliermarsh self-assigned this Nov 11, 2022
@charliermarsh charliermarsh mentioned this issue Nov 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
isort Related to import sorting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support isort: skip, isort: on, and isort: off astral-sh/ruff
2 participants
@andersk @charliermarsh