Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apparent duplicate rule (S307 and PGH001) #7283

Open
Tracked by #2714
tjkuson opened this issue Sep 11, 2023 · 2 comments
Open
Tracked by #2714

Apparent duplicate rule (S307 and PGH001) #7283

tjkuson opened this issue Sep 11, 2023 · 2 comments
Assignees
@charliermarsh
Labels
rule Implementing or modifying a lint rule

Comments

@tjkuson
Copy link
Contributor

tjkuson commented Sep 11, 2023

Rules suspicious-eval-usage (S307) and eval (PGH001) seem to do the same thing. If they are, in fact, distinct, then the difference between them should probably be explained in the documentation.
@zanieb
Copy link
Member

zanieb commented Sep 11, 2023

I can confirm these look duplicated and have separate implementations. I'm not sure what we should do about it though.

@zanieb zanieb added the needs-decision Awaiting a decision from a maintainer label Sep 11, 2023
@charliermarsh
Copy link
Member

We should remove PGH001, and add a redirect to S307 (IMO).

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Sep 19, 2023
@charliermarsh charliermarsh mentioned this issue Sep 19, 2023
Closed
@charliermarsh charliermarsh self-assigned this Sep 19, 2023
@charliermarsh charliermarsh removed the needs-decision Awaiting a decision from a maintainer label Sep 19, 2023
@lsorber lsorber mentioned this issue Feb 28, 2024
Merged
@dhruvmanila dhruvmanila mentioned this issue May 13, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate PGH001 in favor of S307 astral-sh/ruff
3 participants
@charliermarsh @zanieb @tjkuson