Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking pool doesn't have backpressure on OSX #126

Open
vertexclique opened this issue Aug 29, 2019 · 4 comments
Open

Blocking pool doesn't have backpressure on OSX #126

vertexclique opened this issue Aug 29, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@vertexclique
Copy link
Member

vertexclique commented Aug 29, 2019

Longhauling blocking requests are panicking the blocking thread pool because max threads is not 10_000 for OSX. It is 4096. Current method panics.

Solution: having a variable max threads based on errors coming up from thread pool during spawning dynamic threads.

@yoshuawuyts
Copy link
Contributor

This seems like it'll be resolved by #181.

@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Sep 18, 2019
@vertexclique
Copy link
Member Author

vertexclique commented Sep 20, 2019

No, it is not solved by that PR yet:

running 1 test
thread 'longhauling_task_join' panicked at 'cannot start a dynamic thread driving blocking tasks: Os { code: 35, kind: WouldBlock, message: "Resource temporarily unavailable" }', src/libcore/result.rs:1084:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
test longhauling_task_join ... FAILED

failures:

failures:
    longhauling_task_join

@yoshuawuyts
Copy link
Contributor

@vertexclique do you have a repro perhaps?

@vertexclique
Copy link
Member Author

Yes, It was fixed in the EMA branch. I wrote tests for these cases too. Reopened the branch again so you can take a look to test called longhauling_task_join. Also wrote in the PR how it can be run:
#108 (comment)
branch is here: https://github.com/vertexclique/async-std/tree/ema-based-statistically-adaptive-thread-pool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants